Skip to content

Legislator page (header)#2122

Open
mertbagt wants to merge 30 commits into
codeforboston:mainfrom
mertbagt:legislator-header
Open

Legislator page (header)#2122
mertbagt wants to merge 30 commits into
codeforboston:mainfrom
mertbagt:legislator-header

Conversation

@mertbagt
Copy link
Copy Markdown
Collaborator

@mertbagt mertbagt commented May 6, 2026 •
edited
Loading

Summary

Issue #2126

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • [n/a] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

image image

Known issues

  1. need to update viableCourts variable from a static test value to an array of courts the legislator served on
    • need to calculate Terms Served and Incumbency off of firebase
  2. example: "District X * 9th Hampton" -> the database has the info for "9th Hampton" but it is unclear how to calculate X if we even have the necessary information to calculate X
  3. example: "State Representative * Springfield, Mass." need Town, Mass profile property

Steps to test/reproduce

  1. Go to ./legislators/profile?id=XBPiuP0JN5ZwAMXb19j68GJduuO2

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment May 27, 2026 12:01am

Request Review

@mertbagt mertbagt marked this pull request as draft May 6, 2026 18:24
@mertbagt mertbagt changed the title Legislator header Legislator Header May 6, 2026
@mertbagt mertbagt changed the title Legislator Header Legislator page (Header) May 6, 2026
@mertbagt mertbagt changed the title Legislator page (Header) Legislator page (header) May 6, 2026
@mertbagt mertbagt marked this pull request as ready for review May 12, 2026 23:44
@Mephistic
Copy link
Copy Markdown
Collaborator

Mephistic commented May 27, 2026

As per your comments:

  • viableCourts will be available soon - we just need to finish the in-progress backfill of older courts to have the full dataset, and need to augment the Member scraper to check for historical court data and add that into the Member document.
  • There are different formats for Senate and House members - I think Senate is broken up by numbered Districts (e.g. District 19 - First Essex) - see (https://malegislature.gov/assets/redistricting/Senate%20Map%20Key-2021.pdf), while House seems to use just the names (e.g. First Essex)
  • I'm not sure where the actual town data comes from - it might need to be legislator provided (or pulled from other publically available records?) - let's skip for now and circle back with Matt V

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball is a code owner

@Mephistic Mephistic Awaiting requested review from Mephistic Mephistic is a code owner

@kiminkim724 kiminkim724 Awaiting requested review from kiminkim724 kiminkim724 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mertbagt @Mephistic